Skip to content

correcting the logical and physical PID of hwloc #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergioMartin86 merged 1 commit into from
Sep 18, 2025
Merged

correcting the logical and physical PID of hwloc #41

SergioMartin86 merged 1 commit into from
Sep 18, 2025

Conversation

@noabauma
Copy link
Collaborator

@noabauma noabauma commented Sep 17, 2025

Description

The hwloc fix was close to being correct, just a minor fix.

Type of change

What type of changes does your code introduce to HiCR? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the testing guidelines for recommendations about automated tests.

@noabauma noabauma self-assigned this Sep 17, 2025
@noabauma noabauma added the bug Something isn't working label Sep 17, 2025
@github-actions
Copy link

github-actions bot commented Sep 17, 2025

Coverage arm64

Code Coverage

Package Line Rate Branch Rate Health
include.hicr.backends.boost 75% 43% ➖
include.hicr.backends.hwloc 76% 37% ➖
include.hicr.backends.mpi 96% 53% ✔
include.hicr.backends.nosv 71% 45% ➖
include.hicr.backends.pthreads 84% 44% ✔
include.hicr.core 72% 44% ➖
include.hicr.frontends.RPCEngine 100% 48% ✔
include.hicr.frontends.channel 95% 63% ✔
include.hicr.frontends.channel.fixedSize 100% 50% ✔
include.hicr.frontends.channel.fixedSize.mpsc.locking 91% 57% ✔
include.hicr.frontends.channel.fixedSize.mpsc.nonlocking 96% 55% ✔
include.hicr.frontends.channel.fixedSize.spsc 95% 68% ✔
include.hicr.frontends.channel.variableSize 92% 50% ✔
include.hicr.frontends.channel.variableSize.mpsc.locking 84% 48% ✔
include.hicr.frontends.channel.variableSize.mpsc.nonlocking 95% 47% ✔
include.hicr.frontends.channel.variableSize.spsc 91% 54% ✔
include.hicr.frontends.objectStore 63% 41% ➖
include.hicr.frontends.tasking 80% 56% ✔
Summary 82% (1814 / 2202) 47% (1093 / 2337) ✔

Minimum allowed line rate is 60%

@github-actions
Copy link

github-actions bot commented Sep 17, 2025

Coverage amd64

Code Coverage

Package Line Rate Branch Rate Health
include.hicr.backends.boost 75% 43% ➖
include.hicr.backends.hwloc 76% 37% ➖
include.hicr.backends.mpi 96% 53% ✔
include.hicr.backends.nosv 71% 45% ➖
include.hicr.backends.pthreads 84% 44% ✔
include.hicr.core 72% 44% ➖
include.hicr.frontends.RPCEngine 100% 49% ✔
include.hicr.frontends.channel 95% 63% ✔
include.hicr.frontends.channel.fixedSize 100% 50% ✔
include.hicr.frontends.channel.fixedSize.mpsc.locking 91% 57% ✔
include.hicr.frontends.channel.fixedSize.mpsc.nonlocking 96% 57% ✔
include.hicr.frontends.channel.fixedSize.spsc 95% 68% ✔
include.hicr.frontends.channel.variableSize 90% 50% ✔
include.hicr.frontends.channel.variableSize.mpsc.locking 84% 48% ✔
include.hicr.frontends.channel.variableSize.mpsc.nonlocking 95% 48% ✔
include.hicr.frontends.channel.variableSize.spsc 91% 54% ✔
include.hicr.frontends.objectStore 63% 41% ➖
include.hicr.frontends.tasking 80% 56% ✔
Summary 82% (1811 / 2199) 47% (1094 / 2333) ✔

Minimum allowed line rate is 60%

@SergioMartin86 SergioMartin86 merged commit 24d003a into master Sep 18, 2025
15 checks passed
@noabauma noabauma deleted the hwloc_fix branch September 18, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioMartin86 SergioMartin86 Awaiting requested review from SergioMartin86

Assignees

@noabauma noabauma

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noabauma @SergioMartin86